perfect_gas.test - Fixes to decrease false failure rates. #129
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
perfect_gas.test
sets a random state and gradient to testPerfectMixture
class methods.This state and gradient are occasionally set to outliers and cause a false failure for
ComputePressureDerivative
test, mainly for two reasons:These are false failures, not due to actual malfunctioning of class methods. To decrease false-failure rates, following fixes are made:
After this fix, no false failure was found from 100 tests. (used to be ~10).