Improvements and bug fixes for LTE+Mixing-Length model #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a variable order restart, in M2ulPhyS::restart_files_hdf5, the primitive variable array was initialized incorrectly. In a practical simulation, this is irrelevant, since the primitives are computed prior to the evaluation of the right-hand-side. But, if we are going to bother to do it (e.g., in case a visualization file is written before a time step is taken), the calculation should be correct.
trevilo
force-pushed
the
lte-mix-usability-rebase
branch
2 times, most recently
from
e39f68c
to
8e85298
Compare
Before it was based on the divergence free piece of the strain rate tensor S, but it should be just S itself.
trevilo
force-pushed
the
lte-mix-usability-rebase
branch
from
8e85298
to
2b7cf96
Compare
trevilo
commented
Aug 25, 2023
src/mixing_length_transport.cpp
Outdated
|
|
||
| transportBuffer[FluxTrns::VISCOSITY] += mut; | ||
| transportBuffer[FluxTrns::BULK_VISCOSITY] += mut; |
trevilo
commented
Aug 25, 2023
src/mixing_length_transport.hpp
Outdated
|
|
||
| visc[0] += mut; | ||
| visc[1] += mut; |
After fixes to mixing length viscosity calc, as well as bug fix in getting the distance fcn on shared faces, and using the useBCinGrad option to get some regression coverage on that code path.
First, evaluate electrical conductivity in LTE transport. Second, make sure electron thermal conductivity is initialized (to zero) by LTE transport. The reason to set it to zero is that it is already incorporated into the "total" conductivity that is used to set the heavy species conductivity. Since the flux function adds the electron conductivity (in the single T model), we must set it to zero to avoid either using potentially uninitialized space or double counting a piece of the conductivity.
to allow user to supply a function of space if desired. An example is in comments, but leave the standard case as just a constant.
This function allows us to update the electrical conductivity just prior to EM solve, which is required for proper restarts. Also, we include a flag enabling the user to skip this update. This can be useful for ramping up cases by generating a Joule heating based on an artificial electrical conductivity field.
from becoming negative (joule) or too small (conductivity)
B/c there is now a check for negative Joule heating where the forcing is added, this test has changed slightly. B/c of interpolation, the Joule heating can go slightly negative on the flow mesh, which is happening in this case. Previously these negative values were added. Now, the Joule heating is only added if it is non-negative. This modification changes the solution, leading to this reference solution update.
trevilo
force-pushed
the
lte-mix-usability-rebase
branch
from
2b7cf96
to
044f0f5
Compare
|
Unable to reproduce failing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These mods have been in use on dev branches for awhile, so it is time to get them onto main.
This includes