Fixes and testing for Tomboulides class in gpu builds
#267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vice
By default for device-enabled runs, all ParGridFunction objects set
UseDevice(true) for their underlying Vector. This can break the curl
calculations (ComputeCurl{2D,3D,Axi}) because they *assume* all host
is valid. This commit is the minimal necessary for these fcns to
protect themselves and return valid results (on the host of course).
The u_next_rad_comp_gf_ ParGridFunction seems to be causing problems on some gpu systems. This is intended to alias the first (i.e. radial) component of the velocity grid function. It is constructed via u_next_rad_comp_gf_ = new ParGridFunction(pfes_, *u_next_gf_); But, this leads to failures like the following: Verification failed: (IsHostMemory(h_mt)) is false in mfem::MFEM_VERIFY_TYPES, which is called (eventually) from Vector::HostRead. Initially I thought this had to do with a failure to properly call Vector::SyncMemory, since the base memory (in u_next_gf_) is being modified. But, an attempt to use this had no impact on the problem. So, in this workaround, I eliminate the alias and simply copy the first component into a new grid function. This seems to work, but it would be nice to understand the problem with the original approach, b/c clearly we'd rather not copy when it shouldn't be necessary.
trevilo
force-pushed
the
fix-tomboulides-gpu
branch
from
852f435
to
0286e96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some bug fixes and testing for the low Mach flow solver in gpu builds. Three notes:
lomach-lequere.test), which is expected b/c the environment is different from that where the regression tests were established.cusparse_SpMVusingCUSPARSE_SPMV_CSR_ALG1(see documentation here) but this should be examined more carefully.