You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Problem: The route and router are hard-coded to HTTP verbs. This prevents the module from being used on other (similar) protocols, where it would be advantageous to do so. It also prevents the router from doing pure-path routing, where verbs don't make sense.
Proposed Solution:
In the new module refactor, route emerged as a standalone module.
Going forward, its namespace should be changed from io.pedestal.http.route.* to just io.pedestal.route.*, and the routers should be updated to be passed the "acceptable verb-set" as an argument in their creation.
This would allow the routers to be used for other protocols, common in service-to-service communication.
The text was updated successfully, but these errors were encountered:
This is now on master -- many thanks to @timewald for doing the leg work to dive back into this.
All routers are verb neutral (they'll work with any verb - verb comparison is made with the :request-method of a request map). The Table/Tabular route definition is the only route definition that currently supports pluggable/parameterized verbs. You can pass in your :verbs set via the options map.
There are some utilities that may not work with custom verbs. If you hit one of those, please open up a new issue.
The router and route definition namespaces may be adjusted in a future release (since they are no longer http specific.
Problem: The route and router are hard-coded to HTTP verbs. This prevents the module from being used on other (similar) protocols, where it would be advantageous to do so. It also prevents the router from doing pure-path routing, where verbs don't make sense.
Proposed Solution:
In the new module refactor,
route
emerged as a standalone module.Going forward, its namespace should be changed from
io.pedestal.http.route.*
to justio.pedestal.route.*
, and the routers should be updated to be passed the "acceptable verb-set" as an argument in their creation.This would allow the routers to be used for other protocols, common in service-to-service communication.
The text was updated successfully, but these errors were encountered: