Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Default 404 handler #19

Merged
merged 2 commits into from
Jul 18, 2017
Merged

feat: Default 404 handler #19

merged 2 commits into from
Jul 18, 2017

Conversation

MiniGod
Copy link
Contributor

@MiniGod MiniGod commented Jun 12, 2017

If no route was found, then reply with a 404. The text in the body is inspired by express.

Fixes #18

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 22a98ec on MiniGod:default-404 into 78938a3 on pedronauck:master.

@pedronauck
Copy link
Owner

Please @MiniGod, use send method from micro insteado of res ✌️

@MiniGod
Copy link
Contributor Author

MiniGod commented Jun 13, 2017

Done. Please note that this then adds micro as a dependency!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2bbe86c on MiniGod:default-404 into 78938a3 on pedronauck:master.

@ccutch
Copy link

ccutch commented Jul 18, 2017

Please review

@pedronauck pedronauck merged commit c9fca3a into pedronauck:master Jul 18, 2017
@MiniGod MiniGod deleted the default-404 branch July 19, 2017 15:27
@agurtovoy agurtovoy mentioned this pull request Aug 24, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MiniGod @coveralls @pedronauck @ccutch