Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code splitting: homepage gets smaller bundle #72

Merged
merged 2 commits into from
Oct 27, 2017
Merged

code splitting: homepage gets smaller bundle #72

merged 2 commits into from
Oct 27, 2017

Conversation

pgte
Copy link
Collaborator

@pgte pgte commented Oct 26, 2017

No description provided.

@pgte pgte requested a review from olizilla October 26, 2017 21:40
@pgte
Copy link
Collaborator Author

pgte commented Oct 27, 2017

This last commit makes the homepage load in Safari, even though clicking on the "create" buttons doesn't work (because of what looks like some problem of webcrypto-shim in Safari).

olizilla
olizilla approved these changes Oct 27, 2017
View reviewed changes
Copy link
Collaborator

@olizilla olizilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me in Safari 11, when merged with master.
Home page bundle is now ~500K which is more reasonable.

👍

@olizilla olizilla merged commit f53986d into master Oct 27, 2017
@olizilla olizilla deleted the codesplit branch October 27, 2017 10:12
@olizilla olizilla mentioned this pull request Oct 27, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olizilla olizilla olizilla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pgte @olizilla