Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add prettier-plugin-sort-imports (was previously removed because of import attributes issue) #141

Closed
jhnns opened this issue Apr 29, 2024 · 2 comments
Closed

Re-add prettier-plugin-sort-imports (was previously removed because of import attributes issue) #141

jhnns opened this issue Apr 29, 2024 · 2 comments

Comments

@jhnns
Copy link
Member

jhnns commented Apr 29, 2024 •
edited
Loading

There is an issue with prettier-plugin-sort-imports that is caused by using import attributes like import ... with { type: "json" }: trivago/prettier-plugin-sort-imports#270

Since there's not a good workaround, the only option for now is to temporarily disable the plugin 😢. We should re-add it once it got fixed upstream.
jhnns added a commit that referenced this issue Apr 29, 2024
@jhnns
fix: Disable @trivago/prettier-plugin-sort-imports temporarily
fe7326f 
See #141
@jhnns jhnns mentioned this issue Apr 29, 2024
Merged
jhnns added a commit that referenced this issue Apr 29, 2024
@jhnns
fix: Disable @trivago/prettier-plugin-sort-imports temporarily (#142)
501c74e 
See #141
@jhnns jhnns changed the title Disable prettier-plugin-sort-imports because of import attributes issue Re-add prettier-plugin-sort-imports (was previously removed because of import attributes issue) May 6, 2024
@jhnns
Copy link
Member Author

jhnns commented Jul 17, 2024

We could also try out https://github.com/IanVS/prettier-plugin-sort-imports

@jhnns
Copy link
Member Author

jhnns commented Sep 13, 2024

Fixed by 0c1eb54

@jhnns jhnns closed this as completed Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jhnns