Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error messages #371

Closed
2 tasks done
dmajda opened this issue Sep 11, 2015 · 0 comments
Closed
2 tasks done

Improve error messages #371

dmajda opened this issue Sep 11, 2015 · 0 comments
Labels
feature
Milestone
0.10.0

Comments

@dmajda
Copy link
Contributor

dmajda commented Sep 11, 2015 •
edited

  • Add Oxford comma in syntax error message
  • Review error messages for style and consistency
@dmajda dmajda added the feature label Sep 11, 2015
@dmajda dmajda added this to the 0.10.0 milestone Sep 11, 2015
dmajda added a commit that referenced this issue Jul 3, 2016
@dmajda
Grammar error messages 1/3: Improve the missing rule message
85fb8aa 
New wording is more similar to wording used in various programming
languages and it is in line with the duplicate rule message.

Part of #371.
dmajda added a commit that referenced this issue Jul 3, 2016
@dmajda
Grammar error messages 2/3: Improve the infinite loop message
f5e43f8 
New wording is more explanatory.

Part of #371.
dmajda added a commit that referenced this issue Jul 3, 2016
@dmajda
Grammar error messages 3/3: Improve the left recursion message
ec8ede5 
New wording is more explanatory.

Part of #371.
dmajda added a commit that referenced this issue Jul 3, 2016
@dmajda
Syntax error messages: Use Oxford comma
b3a90de 
In general PEG.js uses American English, where Oxford comma is
prevalent.

Part of #371.
@dmajda dmajda closed this as completed Jul 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
0.10.0
Development

No branches or pull requests
1 participant
@dmajda