Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/openmetrics #113

Merged
merged 10 commits into from
Aug 13, 2023
Merged

Feature/openmetrics #113

merged 10 commits into from
Aug 13, 2023

Conversation

davidshadix
Copy link
Contributor

This pull request enables the exporter to proxy Open Metrics from Jfrog Platform services.

Please let me know any feedback you have 😄

@sonarcloud
Copy link

sonarcloud bot commented Aug 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

peimanja
peimanja approved these changes Aug 13, 2023
View reviewed changes
Copy link
Owner

@peimanja peimanja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks for the contribution ! I will test it out soon and will release a new version then. Meanwhile you can use canary tag

@peimanja peimanja merged commit 90e6a9c into peimanja:master Aug 13, 2023
2 checks passed
@davidshadix
Copy link
Contributor Author

I deployed the canary version, will report back if I notice anything odd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peimanja peimanja peimanja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidshadix @peimanja