Address alias #61
Merged
Address alias #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oi,admin'. add comments. update tests
| @@ -160,8 +160,9 @@ module.exports.tests.sanitize_layers = function(test, common) { | |||
| }); | |||
| test('invalid layer', function(t) { | |||
| sanitize({ layers: 'test_layer', input: 'test', lat: 0, lon: 0 }, function( err, clean ){ | |||
| var msg = 'invalid param \'layer\': must be one or more of geoname,osmnode,osmway,admin0,admin1,admin2,neighborhood,poi,admin'; | |||
There was a problem hiding this comment.
I changed the way this test runs in an attempt to make it less brittle when new layers are added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts to expose the new
addresstypes via the API, initially justopenaddressesbut later alsoTIGER,openvenuesetc.I think it's best to introduce a new
aliasfor addresses, so we can turn them on/off and have query-time control over what is returned (just like the existingpoi/adminaliases).In this PR I've also slightly changed the way we assign
defaultlayers, in the past we defaulted to all layers, now if you fail to specify a layers param in yourGETrequest it'll default topoi,admin.Maybe later we can change that to include
addressbut need to do some testing first.related: pelias/schema#36
cc/ @hkrishna