fix(cli): Handle chown failures when running as non-root #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #55 we added a `chown` line that attempts to set proper permissions on the Elasticsearch data directory. `chown` can generally only be run as root, so this PR adds handling for the common case where `chown` fails. In general, either the pelias CLI is run as root, and the `chown` will succeed, or the CLI is run as the same user the Docker container processes will run as. In this case the `mkdir` on the preceding line will set up the directory with proper ownership. We can't really do anything in an automated way to handle people running the Pelias CLI as a different, non-root, user than the one they want the containers to run with, so I think this is the best we can do. This will be even more useful once #62 is merged.
orangejulius
force-pushed
the
better-chown-handling
branch
from
eb90a40
to
4c131c5
Compare
calpb
pushed a commit
to sorelle/docker
that referenced
this pull request
Mar 29, 2021
fix(cli): Handle chown failures when running as non-root
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #55 we added a
chownline that attempts to set proper permissions on the Elasticsearch data directory.chowncan generally only be run as root, so this PR adds handling for the common case wherechownfails.In general, either the pelias CLI is run as root, and the
chownwill succeed, or the CLI is run as the same user the Docker container processes will run as. In this case themkdiron the preceding line will set up the directory with proper ownership.We can't really do anything in an automated way to handle people running the Pelias CLI as a different, non-root, user than the one they want the containers to run with, so I think this is the best we can do.
This will be even more useful once #62 is merged.