Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow? should return false if no token is found #137

Merged
merged 1 commit into from
Sep 24, 2013
Merged

allow? should return false if no token is found #137

merged 1 commit into from
Sep 24, 2013

Conversation

thetizzo
Copy link
Contributor

In application_controller_methods.rb:

Authenticator#allow? should return false if the token method returns nil.

Currently it returns true but doesn't set current_user because of the if statement which will allow you to have access to the endpoint even if there isn't a token in the request header.

pelle added a commit that referenced this pull request Sep 24, 2013
allow? should return false if no token is found
@pelle pelle merged commit 5c2b591 into pelle:master Sep 24, 2013
gdavison pushed a commit to gdavison/oauth-plugin that referenced this pull request Jan 22, 2014
…w work) and pelle#137 (allow? will now return false when the token is not found)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants