Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule-based engine doesn't respect specified languages #23

Closed
krzysztofcybulski opened this issue Feb 3, 2020 · 1 comment
Closed

Rule-based engine doesn't respect specified languages #23

krzysztofcybulski opened this issue Feb 3, 2020 · 1 comment
Labels
bug Something isn't working
Milestone
Lingua 0.6.1

Comments

@krzysztofcybulski
Copy link

krzysztofcybulski commented Feb 3, 2020 •
edited
Loading

Rule-based engine is ignoring list of languages loaded in LanguageDetector.

LanguageDetectorBuilder
            .fromLanguages(ENGLISH, SPANISH).build()
            .detectLanguageOf(text = "你好，世界")

will return CHINESE, where I expect to receive UNKNOWN.
@pemistahl pemistahl added the bug Something isn't working label Feb 4, 2020
@pemistahl pemistahl added this to the Lingua 0.6.1 milestone Feb 4, 2020
@pemistahl
Copy link
Owner

Hah, good catch @krzysztofpcy. Thank you. I'm going to fix this soon.

pemistahl added a commit that referenced this issue Feb 6, 2020
@pemistahl
Fix missing language filtering in rule-based engine (#23)
b9ca94c
@pemistahl pemistahl mentioned this issue Feb 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Lingua 0.6.1
Development

No branches or pull requests
2 participants
@pemistahl @krzysztofcybulski