Skip to content
This repository has been archived by the owner on Nov 30, 2020. It is now read-only.

Show chat badges (Turbo, Subscriber, Streamer, Mod, Staff etc.) #20

Closed
pencil opened this issue Jul 24, 2015 · 5 comments
Closed

Show chat badges (Turbo, Subscriber, Streamer, Mod, Staff etc.) #20

pencil opened this issue Jul 24, 2015 · 5 comments

Comments

@pencil
Copy link
Owner

pencil commented Jul 24, 2015

turbo and subscriber flags (true, false) are already recorded as well as the usertype field (mod, global_mod, admin, staff). All that is left is displaying them in the browser extension.

@goldbattle
Copy link
Contributor

https://github.com/justintv/Twitch-API/blob/master/v3_resources/chat.md#get-chatchannelbadges

Should get all the badges needed for a channel.

@tolgap
Copy link
Contributor

tolgap commented Aug 29, 2015

@pencil I have taken a shot at completing @goldbattle 's implementation of chat badges. I have included the user types as well for mod, global_mod, admin and staff. The only question left is, where should I open a pull request? To this repo, or to @goldbattle 's repo? I have mostly used code of @goldbattle but I have also included some style changes. (Like variable naming in camelcase instead of underscores as @pencil does it, and moving badge logic to it's own method etc.)

@goldbattle
Copy link
Contributor

Make the PR to the main repo.
My PR mainly was a starting point for others.

On Sat, Aug 29, 2015 at 9:14 AM, Tolga Paksoy notifications@github.com
wrote:

@pencil https://github.com/pencil I have taken a shot at completing
@goldbattle https://github.com/goldbattle 's implementation of chat
badges. I have included the user types as well for mod, global_mod, admin
and staff. The only question left is, where should I open a pull request?
To this reop, or to @goldbattle https://github.com/goldbattle 's repo?
I have mostly used code of @goldbattle https://github.com/goldbattle
but I have also included some style changes. (Like variable naming in
camelcase instead of underscores as @pencil https://github.com/pencil
does it, and moving badge logic to it's own method etc.)


Reply to this email directly or view it on GitHub
#20 (comment).

@tolgap
Copy link
Contributor

tolgap commented Aug 29, 2015

@goldbattle I'll do it, and thank you for the starting point :)

@pencil
Copy link
Owner Author

pencil commented Dec 19, 2015

I just merged #26 and will rollout the update soonTM. Thank you for your commitment @goldbattle and @tolgap!

@pencil pencil closed this as completed Dec 19, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants