APP-30691 update statstash to report the 99.9 percentile

[vianuevm]

This change is 

[jshore1296]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @vianuevm)

---

statstash.go, line 136 at r1 (raw file):

	s.log.Debugf("record bucketKey: %s", bucketKey)

	if _, err = s.cache.IncrementExisting(bucketKey, delta); err == appwrap.ErrCacheMiss {

Why change increment logic? There's still race conditions in that you're going to lose data if multiple things try to add since only one will get through. We don't need to be super precise here. I'd rather stick to the increment logic since I suspect it's cheaper on the redis side.

[vianuevm]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @jshore1296)

---

statstash.go, line 136 at r1 (raw file):

Previously, jshore1296 wrote…

Why change increment logic? There's still race conditions in that you're going to lose data if multiple things try to add since only one will get through. We don't need to be super precise here. I'd rather stick to the increment logic since I suspect it's cheaper on the redis side.

I didn't actually, I don't know why it thinks I did. If you diff master they are identical?

[jshore1296]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @vianuevm)

---

statstash.go, line 136 at r1 (raw file):

Previously, vianuevm (Michael Vianueva) wrote…

I didn't actually, I don't know why it thinks I did. If you diff master they are identical?

you might need to rebase then.

[vianuevm]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @jshore1296)

---

statstash.go, line 136 at r1 (raw file):

Previously, jshore1296 wrote…

you might need to rebase then.

Now I feel crazy. I did it, didn't work, pulled down master, up to date, rebase again, it works. 🤕

[jshore1296]

Reviewed 2 of 2 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved