add PEN and XLM tokens to Astar portal #1
Conversation
Tested PEN using Cross-chain Transfer(XCM)
Transferred to Astar:
Sent back PEN to Pendulum:
Here are the extrinsic transactions: Test for minimum 0.1 PEN: |
src/modules/xcm/index.ts
Outdated
| [Chain.PENDULUM]: { | ||
| name: Chain.PENDULUM, | ||
| relayChain: Chain.POLKADOT, | ||
| img: require('/src/assets/img/token/pen.png'), |
There was a problem hiding this comment.
How about we add the image as an SVG instead so that it's easily scalable.
There was a problem hiding this comment.
I didn't see a PEN.svg in our drive...?
https://drive.google.com/drive/u/0/folders/1sZcQzoDxT_EUd2wtEJN8ECNzPakfAMs6 only PNG.
I'll ask Anna in the ticket to provide us one.
oh, nvm. the image was
and I missed it.
ok.
src/modules/xcm/tokens/index.ts
Outdated
| symbol: 'PEN', | ||
| isNativeToken: true, | ||
| assetId: '18446744073709551634', | ||
| originAssetId: '0', |
There was a problem hiding this comment.
Looking at the other definitions, I think this should rather be
| originAssetId: '0', | |
| originAssetId: 'PEN', |
though I'm not 100% sure if this is important.
|
|
||
| try { | ||
| // PEN | ||
| if (token.originAssetId == '0') { |
There was a problem hiding this comment.
We would need to change this to == 'PEN' then probably
There was a problem hiding this comment.
Besides that, we do get a isNativeToken boolean passed into this function already. What does that do?
| if (token.id !== '18446744073709551634') { | ||
| throw 'Token must be PEN'; | ||
| } |
There was a problem hiding this comment.
Maybe this condition is too strict and we should remove it. Otherwise, we'll have to change it again once we support more tokens other than PEN.
There was a problem hiding this comment.
i've updated to add XLM and EURC
| if (token.id !== '18446744073709551634') { | ||
| throw 'Token must be PEN'; | ||
| } | ||
| let tokenData = PEN; |
There was a problem hiding this comment.
Then we would probably need to change this to let tokenData = token.originAssetId === "PEN" ? "Native" : { XCM: token.originAssetId } or similiar. Not sure what exactly token.originAssetId can be.
b-yap
changed the title
b-yap
changed the title
|
Cannot test transfer; ASTR Faucet is running out. Putting this on-hold |
b-yap
changed the title
b-yap
changed the title
Tested XLM using Cross-chain Transfer(XCM)
Here are the extrinsic transactions using 0.1 XLM: |
Pull Request Summary
Add support for PEN asset
Closes https://github.com/pendulum-chain/tasks/issues/310 and https://github.com/pendulum-chain/tasks/issues/314
This pull request makes the following changes:
Adds
Fixes
Changes