-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ntp client #138
ntp client #138
Conversation
Codecov Report
@@ Coverage Diff @@
## main #138 +/- ##
==========================================
- Coverage 80.53% 79.22% -1.31%
==========================================
Files 20 22 +2
Lines 4223 4294 +71
==========================================
+ Hits 3401 3402 +1
- Misses 822 892 +70
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly minor comments, though the licensing issue will need fixing.
Other than those, this may also be the time to move the client out of the test-binaries into its own crate. What is your view on that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, nice set of changes
a very rough draft for the client (but everything seems to work)