Add pages (1,2,3) and focus mode #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
- Change "value" string to "notes" array, to store pages 1,2,3 - Add commands to jump to pages 1,2,3 - Update beforeunload to do a bulk save (all at once)
Use chrome.runtime.getBackgroundPage instead of chrome.extension.getBackgroundPage to ensure background page is loaded. Debounce saveNotes on trailing (before leading).
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution to #27 and #28
Changes
chrome.runtime.getBackgroundPagePages
To change the page, you have 2 options:
On Windows, Linux, and Chrome OS:
Ctrl+Shift+1Ctrl+Shift+2Ctrl+Shift+3On Mac:
Option+1Option+2Option+3Focus mode
There is also focus mode added. To hide (toggle) the controls via a keyboard shortcut and to focus on the content.
On Windows, Linux, and Chrome OS:
Ctrl+Shift+FOn Mac:
Option+FScreenshots