Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new latency defs to Fping module, including return values #1

Merged
merged 1 commit into from
Jan 11, 2015

Conversation

nckrse
Copy link
Contributor

@nckrse nckrse commented Jan 6, 2015

Added new latency defs to Fping module, including return values instead of using standard output

I wanted to use this module to return values to send fping metrics to remote destination (graphite in my case). I added two defs:

def * latency: returns LOSS, MIN, AVG, MAX in an array
0
13.7
15.5
17.3
(example code @ https://github.com/pythianreese/graphite-smokeping/blob/master/graphite-smokeping.rb)

def * latency_simple: returns output (not modified)
4.2.2.2 : xmt/rcv/%loss = 6/6/0%, min/avg/max = 13.7/15.5/17.3

penguinpowernz added a commit that referenced this pull request Jan 11, 2015
Added new latency defs to Fping module, including return values
@penguinpowernz penguinpowernz merged commit 28ea56c into penguinpowernz:master Jan 11, 2015
@penguinpowernz
Copy link
Owner

Thanks man!

@nckrse
Copy link
Contributor Author

nckrse commented Jan 13, 2015

Np! You wouldn't mind pushing these changes to rubygems, would you? If any changes need to be made prior, let me know. I would like to use this as a gem dependency without bundler (using github source)

@penguinpowernz
Copy link
Owner

Yep, pushed that up for you now, version 0.2.1. The code you submitted could use a bit of a tidying up but not many people use this gem so it's not urgent (see #2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants