Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image-flash: Pad empty flash partitions to size #102

Merged

Conversation

TobleMiner
Copy link
Contributor

According to the documentation a flash image is

the partition contents padded to the partition sizes concatenated together

Currently empty partitions are not padded to size, resulting in overall
size not equal to the sum of all partition sizes if the last partition
is empty.

Copy link
Member

@michaelolbrich michaelolbrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Just one small issue.

image-flash.c Outdated Show resolved Hide resolved
@TobleMiner TobleMiner force-pushed the fix-flash-partition-padding branch 3 times, most recently from a05d63f to adf18f0 Compare April 17, 2020 07:17
According to the documentation a flash image is
> the partition contents padded to the partition sizes concatenated together

Currently empty partitions are not padded to size, resulting in overall
size not equal to the sum of all partition sizes if the last partition
is empty.

Signed-off-by: Tobias Schramm <tobleminer@gmail.com>
@michaelolbrich michaelolbrich merged commit 3e2a87c into pengutronix:master Apr 17, 2020
@TobleMiner TobleMiner mentioned this pull request Apr 17, 2020
TobleMiner added a commit to TobleMiner/linux2boot that referenced this pull request Apr 17, 2020
Temporary workaround, will eventually be fixed by
pengutronix/genimage#102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants