genimage: support IMAGE_NAME_SUFFIX #123
Conversation
|
For refrerence, the default is set in |
There was a problem hiding this comment.
The functional change looks good to me.
GENIMAGE_ROOTFS_IMAGE and GENIMAGE_ROOTFS_IMAGE_FSTYPE are documented. We should do the same for GENIMAGE_ROOTFS_IMAGE_SUFFIX, maybe with @rohieb's link?
We don't have a mickledore branch, yet. That means mickledore users currently stick to master. This change will break their rootfs unpacking, right? Maybe add a mickledore branch before merging this?
Emantor
force-pushed
the
topic/genimage-image-suffix
branch
from
2914c7f
to
7a395f5
Compare
|
Emantor
force-pushed
the
topic/genimage-image-suffix
branch
from
7a395f5
to
33cd91e
Compare
|
Fixed the typo. |
ejoerns
force-pushed
the
topic/genimage-image-suffix
branch
from
33cd91e
to
e637e04
Compare
|
Rebased on master. |
Since nanbield [1], IMAGE_NAME and IMAGE_LINK_NAME include the IMAGE_NAME_SUFFIX, which means that the rootfs files gain an additional .rootfs suffix. Add support for this in genimage. [1]: https://docs.yoctoproject.org/4.3.1/migration-guides/migration-4.3.html#output-file-naming-changes Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de> Signed-off-by: Enrico Jörns <ejo@pengutronix.de>
ejoerns
force-pushed
the
topic/genimage-image-suffix
branch
from
e637e04
to
fc6db2f
Compare
|
This is now reworked to define I'm not fully sure if it needs a variable or if we can just rely directly on Note that the same change would be useful for |
Since nanbield 1, IMAGE_NAME and IMAGE_LINK_NAME include the IMAGE_NAME_SUFFIX, which means that the rootfs files gain an additional .rootfs suffix. Add support for this in genimage.