genimage.bbclass: disable SSTATE artifact generation and avoid unnecessary rebuilds #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
do_deploy already has the to_build dependency
Without this, do_genimage will always be triggered.
This change is similar to oe-core's f61bcae0 ("image: Drop before
do_build from do_rootfs and do_image") which fixes the same issue for
the image class.
Signed-off-by: Enrico Jörns <ejo@pengutronix.de>
The artifacts created would be quite large and keeping multiple of them will consume a notable amount of disk space while the expected speed-up is really minimal. (For the same reasons, the image class does not generate sstate artifacts). Having SSTATE artifacts enabled here before also led to unexpected/unwanted behavior where a rootfs image recipe was rebuild and the binary output (file system image) changed but did not make it into the final genimage-generated disk image. This becomes a major problem, e.g. in the context of verified boot. Signed-off-by: Enrico Jörns <ejo@pengutronix.de>
Emantor
approved these changes
Jun 7, 2024
|
Backported to |
|
Backported to |
ejoerns
added
kirkstone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes will notably impact how the
genimage.bbclassperforms.They will
Fixes #130