Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

10 !!! #138

Merged
merged 5 commits into from
Nov 28, 2015
Merged

10 !!! #138

merged 5 commits into from
Nov 28, 2015

Conversation

samsonasik
Copy link
Member

here we go ;)

EmanueleMinotto
EmanueleMinotto reviewed Nov 27, 2015
View reviewed changes
src/App.php
PennyEvmInterface $eventManager,
PennyEventInterface $event
) {
if (!($routeInfo instanceof RouteInfoInterface)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just write if (!$routeInfo instanceof RouteInfoInterface) { because the instanceof has higher operator precedence than !.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done ;)

@samsonasik
Copy link
Member Author

@gianarb the score is 10 now \m/ https://scrutinizer-ci.com/g/pennyphp/penny/inspections/778a6191-055d-4e59-b352-c356b9ce58d1

@samsonasik
Copy link
Member Author

need improve a bit, wait a minute

@samsonasik
Copy link
Member Author

@gianarb should be awesome now ;). Zero issues https://scrutinizer-ci.com/g/pennyphp/penny/inspections/3e58191c-64b1-446a-8dfa-41f40fe8f345 with perfect score 10 \m/

@gianarb
Copy link
Contributor

gianarb commented Nov 28, 2015

Thanks @samsonasik for your daily work.. :) Now are you ready to use penny? :D

gianarb pushed a commit that referenced this pull request Nov 28, 2015
Merge pull request #138 from samsonasik/10
fc03a4e 
10 !!!
@gianarb gianarb merged commit fc03a4e into pennyphp:master Nov 28, 2015
@samsonasik
Copy link
Member Author

hopefully ;)

Warm regards,

Abdul Malik Ikhsan

Pada 28 Nov 2015, pukul 16.32, Gianluca Arbezzano notifications@github.com menulis:

Merged #138.

—
Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samsonasik @gianarb @EmanueleMinotto