Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #96 , implements ClassName::class prefix for event name #147

Merged
merged 3 commits into from
Nov 29, 2015

Conversation

samsonasik
Copy link
Member

@gianarb Fixes #96 here we go ;). new format:

  • App\Controller\IndexController.index for 200 status
  • App\Controller\IndexController.dummy_error for throwing Exception

For dispatch_error, we can't have ClassName::class as prefix, as it means no controller registered.

@samsonasik
Copy link
Member Author

@gianarb the flow image in docs need to be updated. could you handle that? Thanks :P

@samsonasik
Copy link
Member Author

@gianarb any suggestion?

@gianarb
Copy link
Contributor

gianarb commented Nov 29, 2015

No problem for the flow image :)

gianarb pushed a commit that referenced this pull request Nov 29, 2015
Fixes #96 , implements ClassName::class prefix for event name
@gianarb gianarb merged commit 4d222b8 into pennyphp:master Nov 29, 2015
@samsonasik
Copy link
Member Author

@gianarb thank you ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase event name readability/writability
2 participants