PHP-CS-Fixer round #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gianarb could we have styleci for it? |
|
you are my nightmares! travis-ci runs php-cs-fix, why should we add styleci? :) |
|
because we don't need to require php code sniffer or php cs fixer anymore, and it faster to check and has automatic pr creation for cs fix from styleci |
|
Ok guys! I will add it as soon as possible |
|
Not really sure about that. Why use an external thing when we can just add a require-dev dependency and a command in the already existing CI ? |
|
I mean automatic is just one click for fix, at least, it was based my experience with it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.