Dispatcher must be a callable

[gianarb]

This is a good way to standardize dispatcher
implementation and to improve future implementations

/cc @wdalmut @ezimuel 👍

[fntlnz]

Interesting approach

[EmanueleMinotto]

What about call_user_func($dispatcher, $request) here?

Penny still requires only PHP 5.4+ and the notation $dispatcher($request) will be indipendent only from PHP 7: https://3v4l.org/Rd6qm

[samsonasik]

anyway, we now require php 5.5 #76

[EmanueleMinotto]

@samsonasik the problem exists for php until 5.6.13 (see the 3v4l link)

[samsonasik]

yup, seems call_user_func is for the rescue now

[samsonasik]

@gianarb I created PR #78 for it

[wdalmut]

👍 @gianarb can you explain here how to use the router callable?

using callable we can use something like this? (see below)

"router" => function (/*...*/) {
  // my router
}

or

"router" => new RouterFactory(/*...*/),

class RouterFactory
{
  public function __invoke(/*...*/) {

  }
}

Right?

Which kind of data type the router callable have to return? Any interface or just another callable (the executable action)?

"router" => function (/*...*/) {
  return function (/*...*/) {
    // Here is my dispatch-able controller
  }
}

[gianarb]

Yes @wdalmut, right your first two examples already work

At the moment after $dispatcher($router) I wait a callable..
Before call it I load controller by Di..
https://github.com/pennyphp/penny/blob/master/src/App.php#L151

[wdalmut]

Here my Penny with a single route and Pimple as a container! (when you fix #77)

<?php
require __DIR__ . '/../vendor/autoload.php';

use GianArb\Penny\App;
use Interop\Container\Pimple\PimpleInterop;
use Zend\EventManager\EventManager;
use Zend\Diactoros\Response\SapiEmitter;

$container = new PimpleInterop();
$container["event_manager"] = function() {
    return new EventManager();
};
$container["dispatcher"] = function($r) {
    return $r["router"];
};
$container["index"] = new Controller();
$container["router"] = function($r) {
    return function ($request) {
        return [
            null,
            ["index", "index"],
            ["ok"],
        ];
    };
};

$emitter = new SapiEmitter();
$app = new App($container);
$emitter->emit($app->run());

class Controller {
    public function index($request, $response)
    {
        $response->getBody()->write("Here is my skeleton");
        return $response;
    }
}

You will see Here is my skeleton

[gianarb]

Easy! :)
You can add this into the Penny\Container\PimpeFactory

$container = new PimpleInterop();
$container["event_manager"] = function() {
    return new EventManager();
};
$container["dispatcher"] = function($r) {
    return $r["router"];
};
$container["index"] = new Controller();
$container["router"] = function($r) {
    return function ($request) {
        return [
            null,
            ["index", "index"],
            ["ok"],
        ];
    };
};

To reuse it :D