Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vercel workflow #819

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Add Vercel workflow #819

merged 3 commits into from
Sep 22, 2023

Conversation

ethitter
Copy link
Member

Switches Vercel deploys to a GitHub action

Make sure you complete these items:

  • Updated root CHANGELOG.md with summary of changes under Unpublished section
  • npm run prod in this repo outputs expected changes (excepting the issue with re-ordered partials in larva-css algorithms partials - see LRVA-1885)
  • If adding a new pattern, in the PR comment, included a screenshot and link to the static Vercel deployment
  • If changes to build scripts or the Node.js server, tested changes in pmc-spark via a pre-release
    • If changes to build tools: npm scripts prod, lint, and dev scripts run as expected
    • If changes to Larva server: Static site generates as expected in a theme (avail. on a URL {brand}.stg.larva.pmcdev.io)

@ethitter ethitter marked this pull request as ready for review September 22, 2023 18:42
@ethitter ethitter merged commit 6241bd5 into master Sep 22, 2023
2 of 3 checks passed
@ethitter ethitter deleted the feature/vercel-github-action branch September 22, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants