fix(minifront): #1598: display non-native-fee-warning per account

[VanishMax]

Closes #1598

Checks if user has UM token in the same account as the selected source token

Kapture.2024-08-01.at.14.24.00.mp4

[changeset-bot]

⚠️ No Changeset found

Latest commit: f3c73d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[Valentine1898]

That can be confusing for users because not every asset can be an alt fee asset
In your demo TestUSD is not an alt fee asset, and it is not the case when a non-native fee asset is used

[VanishMax]

@Valentine1898 do I get it right that, if user has TestUSD (non-alt token) and, let's say, AltUSD (some alt token), and the source token is TestUSD, the fees will still be paid in AltUSD, if the amount is enough to cover the fees?

[Valentine1898]

@Valentine1898 do I get it right that, if user has TestUSD (non-alt token) and, let's say, AltUSD (some alt token), and the source token is TestUSD, the fees will still be paid in AltUSD, if the amount is enough to cover the fees?

Yes, that's right

[VanishMax]

@Valentine1898 @TalDerei I implemented the checks for alt token balances before showing the NonNativeFeeWarning, mainly copied the logic from getAssetFromGasPriceTable service function. Ready for review.

Right now, viewClient.gasPrices({}) returns empty array of altGasPrices for both testnet and penumbra-1. Any idea how to test it locally?

[TalDerei]

Right now, viewClient.gasPrices({}) returns empty array of altGasPrices for both testnet and penumbra-1. Any idea how to test it locally?

to simulate gas prices, add this code block inside the block processor and resync, then check updated GasPrices table.

const assetId1 = new AssetId({
      inner: base64ToUint8Array("drPksQaBNYwSOzgfkGOEdrd4kEDkeALeh58Ps+7cjQs=")
    });

    const assetId2 = new AssetId({
      inner: base64ToUint8Array("B+9mATKkwyNfqyctQ9m5dSqDN7LRCFl6v/r/XyRtDw8=")
    });

    const assetId3 = new AssetId({
      inner: base64ToUint8Array("KSOgqHs6JCHxZcyFPb9zqb2vtdoNlIVktgWcsCF8RAc=")
    });

    await this.indexedDb.saveGasPrices(
      new GasPrices({
        assetId: this.stakingAssetId,
        blockSpacePrice: 60n,
        compactBlockSpacePrice: 1556n,
        verificationPrice: 1n,
        executionPrice: 1n
      }),
    );

    await this.indexedDb.saveGasPrices(
      new GasPrices({
        assetId: assetId1,
        blockSpacePrice: 600n,
        compactBlockSpacePrice: 15560n,
        verificationPrice: 10n,
        executionPrice: 10n
      }),
    );

    await this.indexedDb.saveGasPrices(
      new GasPrices({
        assetId: assetId2,
        blockSpacePrice: 120n,
        compactBlockSpacePrice: 3112n,
        verificationPrice: 2n,
        executionPrice: 2n
      }),
    );

    await this.indexedDb.saveGasPrices(
      new GasPrices({
        assetId: assetId3,
        blockSpacePrice: 1200n,
        compactBlockSpacePrice: 31120n,
        verificationPrice: 20n,
        executionPrice: 20n
      }),
    );

    await this.indexedDb.saveGasPrices(
      new GasPrices({
        assetId: this.stakingAssetId,
        blockSpacePrice: 60n,
        compactBlockSpacePrice: 1556n,
        verificationPrice: 1n,
        executionPrice: 1n
      }),
    );

[Valentine1898]

@VanishMax
It's an RPC bug, here's the fix
#1626

[Valentine1898]

Please rebase on main, I'll review later today

[VanishMax]

@Valentine1898 Updated demo where I added TestUSD to the alt tokens in IndexedDB and showing 3 cases:

1. Account 10 with TestUSD and no UM tokens – warning shows correctly
2. Account 12 with Osmo (not an alt token) – no warning as user can't pay for alt fees this way (we might consider adding validation for this case later)
3. Account 0 (with UM tokens) with GN – no warning as UM will be used to pay for the fees

Kapture.2024-08-02.at.15.24.54.mp4

[TalDerei]

@Valentine1898 Updated demo where I added TestUSD to the alt tokens in IndexedDB and showing 3 cases:

these seem like the proper expected cases to me 👍

[Valentine1898]

Good job!

One suggestion, let's not show a warning for Send if the user has not entered a recipient address, so as not to confuse the user

[TalDerei]

can we combine hasStakingToken and hasAltToken into hasTokenBalance?

[VanishMax]

refactored the code now + removed useShouldRender since there's no need in it after creating hasTokenBalance

[TalDerei]

why do we have a default value for source here?

[TalDerei]

cc @Valentine1898

[VanishMax]

no need, just removed it

[TalDerei]

"The user does not have sufficient balances in alternative tokens to cover the fees."