Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add matched type in PersonEnrichmentResponse interface #206

Closed

Conversation

muzzamilr
Copy link

Description of the change

  • Update the PersonEnrichmentResponse interface by adding "matched" type, because person enrichment api returns matched array of strings when passed a param 'include_if_matched: true' and it's type was not proper in the sdk and I was unable to destructure "matched" or use it like response.matched in typescript.

https://docs.peopledatalabs.com/docs/output-response-person-enrichment-api#matched

Screenshot from 2024-04-23 20-06-38

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • Chore (cleanup or minor QOL tweak that has little to no impact on functionality)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@vvillait88
Copy link
Contributor

@muzzamilr Made your requested changes as part of #214. Closing this PR as a result.

@vvillait88 vvillait88 closed this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants