Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DocuSignClient.get_envelope_document() returns file object with close() method #12

Closed
benoitbryon opened this issue Sep 26, 2014 · 1 comment
Closed

DocuSignClient.get_envelope_document() returns file object with close() method #12

benoitbryon opened this issue Sep 26, 2014 · 1 comment
Assignees
@benoitbryon
Labels
feature
Milestone
0.5 - document.close

Comments

@benoitbryon
Copy link
Contributor

At the moment, the file object returned by DocuSignClient.get_envelope_document() returns file object that has no close() method: https://github.com/novapost/pydocusign/blob/467e4e17bb01879068bcf8f50f3118940ad82c57/pydocusign/client.py#L246
The close() method is implemented in the response object. Not in response.raw.

Without close() method, it is quite hard to explicitely close the connection!
@benoitbryon benoitbryon added this to the Soon milestone Sep 26, 2014
@benoitbryon
Copy link
Contributor Author

Perhaps just add close() attribute to response.raw

@benoitbryon benoitbryon modified the milestones: 0.5 - document.close, Soon Sep 26, 2014
@benoitbryon benoitbryon self-assigned this Sep 26, 2014
benoitbryon added a commit that referenced this issue Sep 26, 2014
@benoitbryon
Refs #12 - DocuSignClient.get_envelope_document() returns a file-like…
d2aa3ef 
… object with a close() method.
@benoitbryon benoitbryon mentioned this issue Sep 26, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benoitbryon benoitbryon

Labels
feature
Projects
None yet
Milestone
0.5 - document.close
Development

No branches or pull requests
1 participant
@benoitbryon