Refactor DocuSignObject and tests
#75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbussell
force-pushed
the
74-refactor-models
branch
from
06a35a5
to
09ddef4
Compare
|
@kbussell can you rebase this PR please ? |
kbussell
force-pushed
the
74-refactor-models
branch
3 times, most recently
from
25362e2
to
5be267a
Compare
|
Ok, sorry for all the interim craziness. That rebase was more painful than it should have been. Anyway, what do you think of the changes? I wanted to make it simpler to add/manage the serialization objects. |
|
Sorry for the delay @kbussell I was in vacations. |
|
@kbussell this PR seems not to be python 3 compliant :/ |
This change makes serializable objects more flexible and less verbose. Tests have been moved to a tests directory to remove visual clutter from the code.
kbussell
force-pushed
the
74-refactor-models
branch
from
5be267a
to
c67e97d
Compare
|
Sorry about that! |
|
It works, thanks for your work @kbussell |
This was referenced Aug 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #74
This change makes serializable objects more flexible and less verbose.
Tests have been moved to a tests directory to remove visual clutter from the code.
Requesting feedback to know if this is easier for people to use and extend from.