Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline interface needs to have a way to tell the summarizer what it produces #32

Closed
nsheff opened this issue Jun 8, 2018 · 7 comments
Assignees
Milestone

Comments

@nsheff
Copy link
Contributor

nsheff commented Jun 8, 2018

Spin-off from #30

How about adding a section like this to pipeline_interface.yaml:

    summary_results:
      "Alignment file": "summary/{project_name}.alignmentPercent.pdf"
      "Library size file": "summary/{project_name}.LibSize.pdf"

the idea is that there would be a few reserved keyword variables like {project_name} that would refer to project attributes, which may be used. or some other way of referring to items in the project config, since the files may want to be named with that information.

@nsheff
Copy link
Contributor Author

nsheff commented Jun 14, 2018

New proposed format enables thumbnails and descriptions:

    summary_results:
      - alignment_file:
        caption: "Alignment file"
        description: "Plots alignment rates to all pre-alignments and primary genome."
        thumbnail_path: "summary/{name}.alignmentPercent.png"
        path: "summary/{name}.alignmentPercent.pdf"
      - lib_file:
        caption: "Library size file"
        thumbnail_path: "summary/{name}.LibSize.png"
        path: "summary/{name}.LibSize.pdf"

@nsheff
Copy link
Contributor Author

nsheff commented Jun 14, 2018

Here {name} will be any project-level attribute

@nsheff
Copy link
Contributor Author

nsheff commented Jun 15, 2018

Now implemented in #34.

@nsheff
Copy link
Contributor Author

nsheff commented Oct 22, 2018

You can see this in action now in pepatac:

https://github.com/databio/pepatac/blob/master/pipeline_interface.yaml

@nsheff
Copy link
Contributor Author

nsheff commented Oct 22, 2018

Before I close this we need to document this in the pipeline interface documentation.

@vreuter
Copy link
Member

vreuter commented Apr 26, 2019

@nsheff this can be closed if the added docs are satisfactory; feel free obviously to change as you see fit

@nsheff
Copy link
Contributor Author

nsheff commented Apr 26, 2019

thanks vince. That's great for now. I think I need to comprehensively re-vamp the pipeline interface docs so I'll leave it open for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants