Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get the PID from job execution #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

adarmanto
Copy link

No description provided.

@adarmanto adarmanto mentioned this pull request May 14, 2018
@adarmanto
Copy link
Author

@peppeocchi The unit testing weren't passed successfully due to there uses an output to get the PID. Any idea on this? I can reset the output just after execution anyway.

@saschanos
Copy link

@peppeocchi, can you please add it to the project?

@saschanos
Copy link

@adarmanto, looks like the fix does not return the process id of the php process. It returns the process id of the sh process. If you try to kill the sh process, the php process is still running.

@adarmanto
Copy link
Author

@saschanos it has been a long, and also as noticed my changes also blocked by travis CI, I am happy if you have a better approach on this and cancel this PR.

@peppeocchi
Copy link
Owner

peppeocchi commented Apr 16, 2019

@adarmanto thanks for your PR and sorry if my reply comes so late, I just didn't have time yet to check it but of course I can't merge it until the tests are all pass (the risk is to break somebody else implementation by doing so). If you can make the tests pass I'll be happy to merge it

@saschanos
Copy link

@peppeocchi, are you still working on the project?

@peppeocchi
Copy link
Owner

@saschanos yes I am. If you're wondering why I haven't merged this PR it's because 2 tests are failing and breaking existing functionalities.

@saschanos
Copy link

@peppeocchi, thank you so much :).

@saschanos saschanos mentioned this pull request Jun 13, 2021
@saschanos
Copy link

@peppeocchi, created a merge request (#126) with fixes. Can you please have a look and maybe close this one afterwards?

@adamz01h
Copy link

https://github.com/adamz01h/php-cron-scheduler
I have implemented using a PID written to the lock file to check running processes. If the spawned PID does not match the script that its running it will assume it died and spin up a new instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants