-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get the PID from job execution #53
base: master
Are you sure you want to change the base?
Conversation
@peppeocchi The unit testing weren't passed successfully due to there uses an output to get the PID. Any idea on this? I can reset the output just after execution anyway. |
@peppeocchi, can you please add it to the project? |
@adarmanto, looks like the fix does not return the process id of the php process. It returns the process id of the sh process. If you try to kill the sh process, the php process is still running. |
@saschanos it has been a long, and also as noticed my changes also blocked by travis CI, I am happy if you have a better approach on this and cancel this PR. |
@adarmanto thanks for your PR and sorry if my reply comes so late, I just didn't have time yet to check it but of course I can't merge it until the tests are all pass (the risk is to break somebody else implementation by doing so). If you can make the tests pass I'll be happy to merge it |
@peppeocchi, are you still working on the project? |
@saschanos yes I am. If you're wondering why I haven't merged this PR it's because 2 tests are failing and breaking existing functionalities. |
@peppeocchi, thank you so much :). |
@peppeocchi, created a merge request (#126) with fixes. Can you please have a look and maybe close this one afterwards? |
https://github.com/adamz01h/php-cron-scheduler |
No description provided.