Make tokudb to be built on MacOS X. #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurynas-biveinis
assigned george-lorch and laurynas-biveinis and unassigned george-lorch
vlad-lesin
force-pushed
the
macos-build-5.6
branch
from
804649a
to
57de998
Compare
|
LGTM |
| inline \ | ||
| int \ | ||
| timed_func_name(lock_type_name *mutex, \ | ||
| const struct timespec *abs_timeout) { \ |
There was a problem hiding this comment.
This is not quite the coding style that we are following for TokuDB. It should look more like:
inline int timed_func_name(
lock_type_name* mutex,
const struct timespec* abs_timeout) {
|
So if you can touch up the style bits, this can be merged. Thanks! |
The functions pthread_mutex_timedlock() pthread_rwlock_timedrdlock() pthread_rwlock_timedwrlock() are not implemented in MacOS X, the simplified implementation is added.
vlad-lesin
force-pushed
the
macos-build-5.6
branch
from
57de998
to
f48a52f
Compare
|
George, the style is fixed. |
george-lorch
pushed a commit
to george-lorch/percona-server
that referenced
this pull request
Feb 1, 2017
Upstream commit ID: 9b1fa3d6456042a0eb0e4b256a089866bf6af87d Summary: Although variable length arrays are supported by GCC 4.5 and later, they are not officially part of the C++11 specification and should probably be avoided for the moment. Change the code to use a static array when possible and allocate a buffer when needed. Resolves Issue percona#457 (facebook/mysql-5.6#457) Closes facebook/mysql-5.6#458 Reviewed By: lth Differential Revision: D4247122 Pulled By: jkedgar fbshipit-source-id: 2189dcd Conflicts: storage/rocksdb/ha_rocksdb.cc
george-lorch
pushed a commit
to george-lorch/percona-server
that referenced
this pull request
Feb 3, 2017
Upstream commit ID: 9b1fa3d6456042a0eb0e4b256a089866bf6af87d Summary: Although variable length arrays are supported by GCC 4.5 and later, they are not officially part of the C++11 specification and should probably be avoided for the moment. Change the code to use a static array when possible and allocate a buffer when needed. Resolves Issue percona#457 (facebook/mysql-5.6#457) Closes facebook/mysql-5.6#458 Reviewed By: lth Differential Revision: D4247122 Pulled By: jkedgar fbshipit-source-id: 2189dcd Conflicts: storage/rocksdb/ha_rocksdb.cc
george-lorch
pushed a commit
to george-lorch/percona-server
that referenced
this pull request
Feb 3, 2017
Upstream commit ID: 9b1fa3d6456042a0eb0e4b256a089866bf6af87d Summary: Although variable length arrays are supported by GCC 4.5 and later, they are not officially part of the C++11 specification and should probably be avoided for the moment. Change the code to use a static array when possible and allocate a buffer when needed. Resolves Issue percona#457 (facebook/mysql-5.6#457) Closes facebook/mysql-5.6#458 Reviewed By: lth Differential Revision: D4247122 Pulled By: jkedgar fbshipit-source-id: 2189dcd Conflicts: storage/rocksdb/ha_rocksdb.cc
george-lorch
pushed a commit
to george-lorch/percona-server
that referenced
this pull request
Feb 3, 2017
Upstream commit ID: 9b1fa3d6456042a0eb0e4b256a089866bf6af87d Summary: Although variable length arrays are supported by GCC 4.5 and later, they are not officially part of the C++11 specification and should probably be avoided for the moment. Change the code to use a static array when possible and allocate a buffer when needed. Resolves Issue percona#457 (facebook/mysql-5.6#457) Closes facebook/mysql-5.6#458 Reviewed By: lth Differential Revision: D4247122 Pulled By: jkedgar fbshipit-source-id: 2189dcd Conflicts: storage/rocksdb/ha_rocksdb.cc
george-lorch
pushed a commit
to george-lorch/percona-server
that referenced
this pull request
Feb 3, 2017
Upstream commit ID: 9b1fa3d6456042a0eb0e4b256a089866bf6af87d Summary: Although variable length arrays are supported by GCC 4.5 and later, they are not officially part of the C++11 specification and should probably be avoided for the moment. Change the code to use a static array when possible and allocate a buffer when needed. Resolves Issue percona#457 (facebook/mysql-5.6#457) Closes facebook/mysql-5.6#458 Reviewed By: lth Differential Revision: D4247122 Pulled By: jkedgar fbshipit-source-id: 2189dcd Conflicts: storage/rocksdb/ha_rocksdb.cc
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 23, 2020
Summary: Although variable length arrays are supported by GCC 4.5 and later, they are not officially part of the C++11 specification and should probably be avoided for the moment. Change the code to use a static array when possible and allocate a buffer when needed. Resolves Issue percona#457 (facebook/mysql-5.6#457) Closes facebook/mysql-5.6#458 Reviewed By: lloyd Differential Revision: D4247122 Pulled By: jkedgar fbshipit-source-id: 2189dcd fbshipit-source-id: 3d774c287b8
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Feb 24, 2021
Summary: Although variable length arrays are supported by GCC 4.5 and later, they are not officially part of the C++11 specification and should probably be avoided for the moment. Change the code to use a static array when possible and allocate a buffer when needed. Resolves Issue percona#457 (facebook/mysql-5.6#457) Closes facebook/mysql-5.6#458 Reviewed By: lloyd Differential Revision: D4247122 Pulled By: jkedgar fbshipit-source-id: 2189dcd fbshipit-source-id: 3d774c287b8
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Nov 15, 2021
Summary: Although variable length arrays are supported by GCC 4.5 and later, they are not officially part of the C++11 specification and should probably be avoided for the moment. Change the code to use a static array when possible and allocate a buffer when needed. Resolves Issue percona#457 (facebook/mysql-5.6#457) Closes facebook/mysql-5.6#458 Differential Revision: D4247122 (facebook/mysql-5.6@01089e0) Pulled By: jkedgar fbshipit-source-id: 58f532c61ee
ldonoso
pushed a commit
to ldonoso/percona-server
that referenced
this pull request
Mar 15, 2022
Summary: Although variable length arrays are supported by GCC 4.5 and later, they are not officially part of the C++11 specification and should probably be avoided for the moment. Change the code to use a static array when possible and allocate a buffer when needed. Resolves Issue percona#457 (facebook/mysql-5.6#457) Closes facebook/mysql-5.6#458 Differential Revision: D4247122 Pulled By: jkedgar
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 9, 2024
Summary: Although variable length arrays are supported by GCC 4.5 and later, they are not officially part of the C++11 specification and should probably be avoided for the moment. Change the code to use a static array when possible and allocate a buffer when needed. Resolves Issue percona#457 (facebook/mysql-5.6#457) Closes facebook/mysql-5.6#458 Differential Revision: D4247122 Pulled By: jkedgar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functions
pthread_mutex_timedlock()
pthread_rwlock_timedrdlock()
pthread_rwlock_timedwrlock()
are not implemented in MacOS X, the simplified implementation is added.
http://jenkins.percona.com/view/PS%205.6/job/percona-server-5.6-param/1120/