Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ZenFS installation and configuration instructions #4762

Merged

Conversation

MaisenbacherD
Copy link
Contributor

Signed-off-by: Dennis Maisenbacher dennis.maisenbacher@wdc.com

@percona-ysorokin percona-ysorokin changed the base branch from 8.0 to release-8.0.28-20 May 19, 2022 14:28
@percona-ysorokin
Copy link
Collaborator

@patrickbirch passing this PR to you

@MaisenbacherD
Copy link
Contributor Author

@patrickbirch I addressed your comments on the most recent push :)

Copy link
Contributor

@patrickbirch patrickbirch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I found a few more.
Thank you.

@MaisenbacherD
Copy link
Contributor Author

Thank you @patrickbirch! I addressed your commends :)

@MaisenbacherD
Copy link
Contributor Author

@percona-ysorokin Are the instructions eventually back ported to the 8.0 branch? We would like to link in our documentation to the most recent instructions.

@patrickbirch
Copy link
Contributor

Yes. I would merge this document when we release the next version of 8.0., which should be released soon.

@patrickbirch patrickbirch self-requested a review May 23, 2022 19:49
Copy link
Contributor

@patrickbirch patrickbirch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the auxiliary directory example.

doc/source/myrocks/zenfs.rst Outdated Show resolved Hide resolved
Signed-off-by: Dennis Maisenbacher <dennis.maisenbacher@wdc.com>
Copy link
Contributor

@patrickbirch patrickbirch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alina-derkach-oaza alina-derkach-oaza merged commit 3b19ca4 into percona:release-8.0.28-20 Jun 20, 2022
avodaniel pushed a commit to tempesta-tech/percona-server that referenced this pull request Aug 28, 2022
Signed-off-by: Dennis Maisenbacher <dennis.maisenbacher@wdc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants