-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PMM-7 enable godot
linter rule
#2252
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2252 +/- ##
==========================================
- Coverage 42.98% 42.95% -0.03%
==========================================
Files 386 386
Lines 47994 47994
==========================================
- Hits 20628 20615 -13
- Misses 25439 25451 +12
- Partials 1927 1928 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
1 task
ademidoff
requested review from
a team,
BupycHuk,
talhabinrizwan,
gen1us2k,
recharte,
artemgavrilov and
JiriCtvrtka
as code owners
June 13, 2023 15:27
artemgavrilov
approved these changes
Jun 13, 2023
BupycHuk
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-7
Ref: #1541
Ref: https://github.com/tetafro/godot
Please note, that we have temporarily suppressed the rule that warn on comments that don't end with a dot. That effort is sizeable and should therefore be separate. You can read more in this dedicated issue.