Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-7 enable godot linter rule #2252

Merged
merged 8 commits into from
Jun 13, 2023
Merged

Conversation

ademidoff
Copy link
Member

@ademidoff ademidoff commented Jun 9, 2023

PMM-7

Ref: #1541
Ref: https://github.com/tetafro/godot

Please note, that we have temporarily suppressed the rule that warn on comments that don't end with a dot. That effort is sizeable and should therefore be separate. You can read more in this dedicated issue.

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #2252 (8d9e727) into main (f1e4524) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2252      +/-   ##
==========================================
- Coverage   42.98%   42.95%   -0.03%     
==========================================
  Files         386      386              
  Lines       47994    47994              
==========================================
- Hits        20628    20615      -13     
- Misses      25439    25451      +12     
- Partials     1927     1928       +1     
Flag Coverage Δ
admin 10.43% <ø> (ø)
agent 52.69% <100.00%> (-0.13%) ⬇️
managed 44.23% <ø> (ø)
vmproxy 69.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nts/postgres/pgstatmonitor/pgstatmonitor_models.go 56.21% <ø> (ø)
...ents/postgres/pgstatstatements/pgstatstatements.go 58.69% <ø> (ø)
agent/commands/clients.go 0.00% <ø> (ø)
agent/connectionuptime/service.go 84.14% <ø> (ø)
agent/queryparser/parser.go 81.81% <ø> (ø)
agent/runner/actions/query_transform.go 98.50% <ø> (ø)
agent/tailog/store.go 52.54% <ø> (ø)
managed/cmd/pmm-managed-starlark/main.go 0.00% <ø> (ø)
managed/models/database.go 42.91% <ø> (ø)
managed/services/agents/state.go 0.00% <ø> (ø)
... and 12 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ademidoff ademidoff marked this pull request as ready for review June 13, 2023 15:27
@ademidoff ademidoff requested review from idoqo and removed request for a team June 13, 2023 15:27
@ademidoff ademidoff enabled auto-merge (squash) June 13, 2023 17:53
@ademidoff ademidoff merged commit 018270c into main Jun 13, 2023
@ademidoff ademidoff deleted the PMM-7-enable-godot-linter-rule branch June 13, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants