PMM-7 enable gocritic linter rule
#2281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2281 +/- ##
=======================================
Coverage 42.94% 42.95%
=======================================
Files 386 386
Lines 47994 47976 -18
=======================================
- Hits 20611 20607 -4
+ Misses 25455 25447 -8
+ Partials 1928 1922 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ademidoff
commented
Jun 16, 2023
| @@ -201,7 +201,7 @@ func parseKeyValueFromComment(s string) (map[string]bool, error) { | |||
| func prepareMultilineRegexp() error { | |||
| // to compile regexp only once | |||
| multilineOnce.Do(func() { | |||
| multilineRegexp, errMultiline = regexp.Compile(`(?s)\/\*(.*?)\*\/`) | |||
| multilineRegexp, errMultiline = regexp.Compile(`(?s)\/\*(.*?)\*\/`) //nolint:gocritic | |||
There was a problem hiding this comment.
@JiriCtvrtka I believe we can use regexp.MustCompile everywhere in this file and simplify the code.
There was a problem hiding this comment.
and by using MustCompile we can migrate the initialization of regexps to the top of the file
ademidoff
requested review from
gen1us2k,
recharte,
a team and
JiriCtvrtka
as code owners
ademidoff
requested review from
idoqo and
artemgavrilov
and removed request for
a team
BupycHuk
approved these changes
Jun 19, 2023
| @@ -201,7 +201,7 @@ func parseKeyValueFromComment(s string) (map[string]bool, error) { | |||
| func prepareMultilineRegexp() error { | |||
| // to compile regexp only once | |||
| multilineOnce.Do(func() { | |||
| multilineRegexp, errMultiline = regexp.Compile(`(?s)\/\*(.*?)\*\/`) | |||
| multilineRegexp, errMultiline = regexp.Compile(`(?s)\/\*(.*?)\*\/`) //nolint:gocritic | |||
There was a problem hiding this comment.
and by using MustCompile we can migrate the initialization of regexps to the top of the file
artemgavrilov
approved these changes
Jun 19, 2023
Comment on lines
-104
to
+105
| //nolint:nestif | ||
| if err == nil { | ||
| switch { | ||
| case err == nil: |
There was a problem hiding this comment.
I think it can be just
if err != nil {
if errors.Is(err, rest.ErrNotInCluster) {
in.l.Info("PMM is running outside a kubernetes cluster")
return nil
}
in.l.Errorf("failed getting kubeconfig inside cluster: %v", err)
return nil
}
// Code for case when we don't have error at all
1 task
|
I'll merge this PR to enable the rule and create another issue to address just the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-7
Ref: #1541
This PR: