Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-12741 Percona templated alerts - interval & folder uid #2919

Merged
merged 6 commits into from
May 3, 2024

Conversation

matejkubinec
Copy link
Contributor

PMM-12741

Due to changes in grafana 10.4, usage of folder name instead of folder uid in path would result in a 401.

Support for the evaluation interval was added as it the default flow that grafana currently has for new evaluation groups creation.

Link to the Feature Build: SUBMODULES-3572

Related PRs:

@matejkubinec matejkubinec requested review from BupycHuk and a team as code owners March 21, 2024 11:07
@matejkubinec matejkubinec requested review from idoqo and JiriCtvrtka and removed request for a team March 21, 2024 11:07
@matejkubinec matejkubinec changed the title PMM-12741 Percona templated alerts PMM-12741 Percona templated alerts - interval & folder uid Mar 21, 2024
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 44.36%. Comparing base (3258363) to head (1020137).

Files Patch % Lines
managed/services/grafana/client.go 0.00% 4 Missing ⚠️
managed/services/management/alerting/service.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #2919      +/-   ##
==========================================
+ Coverage   44.32%   44.36%   +0.03%     
==========================================
  Files         368      368              
  Lines       35327    35327              
==========================================
+ Hits        15660    15674      +14     
+ Misses      18058    18042      -16     
- Partials     1609     1611       +2     
Flag Coverage Δ
admin 11.65% <ø> (+0.05%) ⬆️
agent 52.72% <ø> (+0.13%) ⬆️
managed 46.39% <0.00%> (ø)
vmproxy 66.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BupycHuk
Copy link
Member

@matejkubinec please run make format locally to format files

@ademidoff
Copy link
Member

@BupycHuk I wonder if this PR does not constitute a part of API Breaking changes. If yes, then the base branch needs to be https://github.com/percona/pmm/tree/v3-api-breaking-changes.

@matejkubinec
Copy link
Contributor Author

@BupycHuk I wonder if this PR does not constitute a part of API Breaking changes. If yes, then the base branch needs to be https://github.com/percona/pmm/tree/v3-api-breaking-changes.

If the user used the api in the same way as before (without the interval specified), it should work as previously.

@ademidoff
Copy link
Member

@BupycHuk I wonder if this PR does not constitute a part of API Breaking changes. If yes, then the base branch needs to be https://github.com/percona/pmm/tree/v3-api-breaking-changes.

If the user used the api in the same way as before (without the interval specified), it should work as previously.

Right, nevermind :)

@matejkubinec matejkubinec merged commit a262bf3 into v3 May 3, 2024
28 checks passed
@matejkubinec matejkubinec deleted the PMM-12741-percona-templated-alerts branch May 3, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants