-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PMM-12741 Percona templated alerts - interval & folder uid #2919
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v3 #2919 +/- ##
==========================================
+ Coverage 44.32% 44.36% +0.03%
==========================================
Files 368 368
Lines 35327 35327
==========================================
+ Hits 15660 15674 +14
+ Misses 18058 18042 -16
- Partials 1609 1611 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@matejkubinec please run make format locally to format files |
@BupycHuk I wonder if this PR does not constitute a part of API Breaking changes. If yes, then the base branch needs to be |
If the user used the api in the same way as before (without the interval specified), it should work as previously. |
Right, nevermind :) |
PMM-12741
Due to changes in grafana 10.4, usage of folder name instead of folder uid in path would result in a 401.
Support for the evaluation interval was added as it the default flow that grafana currently has for new evaluation groups creation.
Link to the Feature Build: SUBMODULES-3572
Related PRs: