PMM-7 Fix for service accounts tests stability. #2976
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3 #2976 +/- ##
==========================================
- Coverage 44.36% 43.59% -0.78%
==========================================
Files 368 367 -1
Lines 35327 36125 +798
==========================================
+ Hits 15674 15748 +74
- Misses 18042 18766 +724
Partials 1611 1611
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Tests should not be run in parallel. Issue should be fixed, but it is still persists for us in case of many concurrent service account permissions. |
JiriCtvrtka
changed the title
| @@ -292,6 +292,7 @@ func TestServerClientConnection(t *testing.T) { | |||
| assert.Nil(t, authError) | |||
| }) | |||
|
|
|||
| // Beware: Five or more wrong tries will lock user with error message: "Invalid user or password". | |||
There was a problem hiding this comment.
let's change username here to admin1, error message should be the same.
There was a problem hiding this comment.
This is not happening when tests are triggered on github. It can happen when you run them locally multiple times (like -count=5 etc). I added this to not forget this could happen since it is not clear from the error message. Should I keep this comment or remove it?
Fix for service accounts tests stability