PMM-12522 collect chunks metrics in low resolution #2987
+53
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BupycHuk
requested review from
idoqo and
JiriCtvrtka
and removed request for
a team
1 task
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2987 +/- ##
==========================================
- Coverage 43.36% 43.29% -0.08%
==========================================
Files 399 399
Lines 41576 41583 +7
==========================================
- Hits 18030 18002 -28
- Misses 21533 21569 +36
+ Partials 2013 2012 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JiriCtvrtka
reviewed
May 10, 2024
| @@ -70,26 +70,29 @@ func AddScrapeConfigs(l *logrus.Entry, cfg *config.Config, q *reform.Querier, s | |||
| // find Node address where the agent runs | |||
| var paramsHost string | |||
| var paramPMMAgentVersion *version.Parsed | |||
| var pmmAgent *models.Agent | |||
| if agent.PMMAgentID != nil { | |||
| // extract node address through pmm-agent | |||
There was a problem hiding this comment.
Is it really extraction of node address not pmm-agent version?
JiriCtvrtka
approved these changes
May 10, 2024
ademidoff
reviewed
May 11, 2024
ademidoff
approved these changes
May 11, 2024
ademidoff
reviewed
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-12522
Link to the Feature Build: SUBMODULES-3623
If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs:
PMM-12522 collect chunks metrics in low resolution mongodb_exporter#849