Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PMM-12880 Proper skip for MySQL TLS certs. (#2909). #3007

Merged
merged 1 commit into from
May 30, 2024
Merged

PMM-12880 Proper skip for MySQL TLS certs. (#2909). #3007

merged 1 commit into from
May 30, 2024

Conversation

JiriCtvrtka
Copy link
Contributor

Merged in v2. PR created to include it also into v3.

@JiriCtvrtka
PMM-12880 Proper skip for MySQL TLS certs. (#2909)
59c15eb 
* PMM-12880 Proper skip for TLS certs.

* PMM-12880 Lint.

* PMM-12880 Add comment.

* PMM-12880 Another comment.
@JiriCtvrtka JiriCtvrtka marked this pull request as ready for review May 30, 2024 08:18
@JiriCtvrtka JiriCtvrtka requested a review from a team as a code owner May 30, 2024 08:18
@JiriCtvrtka JiriCtvrtka enabled auto-merge (squash) May 30, 2024 08:18
@codecov Codecov
Copy link

codecov bot commented May 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 58.33333% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 44.42%. Comparing base (39dce06) to head (59c15eb).

Files Patch % Lines
agent/tlshelpers/mysql.go 0.00% 5 Missing ⚠️
agent/agents/mysql/perfschema/perfschema.go 0.00% 1 Missing ⚠️
agent/agents/mysql/slowlog/slowlog.go 0.00% 1 Missing ⚠️
agent/connectionchecker/connection_checker.go 50.00% 1 Missing ⚠️
agent/runner/actions/common.go 50.00% 1 Missing ⚠️
agent/serviceinfobroker/service_info_broker.go 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##               v3    #3007      +/-   ##
==========================================
- Coverage   44.42%   44.42%   -0.01%     
==========================================
  Files         368      368              
  Lines       35468    35469       +1     
==========================================
  Hits        15757    15757              
- Misses      18096    18097       +1     
  Partials     1615     1615
Flag Coverage Δ
agent 52.74% <50.00%> (-0.01%) ⬇️
managed 46.42% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JiriCtvrtka JiriCtvrtka merged commit 8d3e0bf into v3 May 30, 2024
23 checks passed
@JiriCtvrtka JiriCtvrtka deleted the PMM-12880-tls-skip branch May 30, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BupycHuk BupycHuk BupycHuk approved these changes

@ademidoff ademidoff ademidoff approved these changes

@idoqo idoqo Awaiting requested review from idoqo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JiriCtvrtka @ademidoff @BupycHuk