Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-12910 snooze updates #3018

Merged
merged 9 commits into from
Aug 19, 2024
Merged

PMM-12910 snooze updates #3018

merged 9 commits into from
Aug 19, 2024

Conversation

idoqo
Copy link
Contributor

@idoqo idoqo commented Jun 6, 2024

PMM-12910

Link to the Feature Build: SUBMODULES-0

If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:

  • API Docs updated

If this PR is related to some other PRs in this or other repositories, please provide links to those PRs:

  • Links to related pull requests (optional).

@idoqo idoqo requested review from BupycHuk and a team as code owners June 6, 2024 08:45
@idoqo idoqo requested review from ademidoff and JiriCtvrtka and removed request for a team June 6, 2024 08:45
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 23.07692% with 10 lines in your changes missing coverage. Please review.

Project coverage is 44.58%. Comparing base (6a42b21) to head (6ba9f9e).
Report is 1 commits behind head on v3.

Files Patch % Lines
managed/models/user_flags_model_reform.go 42.85% 4 Missing ⚠️
managed/services/user/user.go 0.00% 4 Missing ⚠️
managed/models/user_flags_helpers.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #3018      +/-   ##
==========================================
+ Coverage   44.56%   44.58%   +0.02%     
==========================================
  Files         357      357              
  Lines       35567    35577      +10     
==========================================
+ Hits        15849    15862      +13     
+ Misses      18096    18095       -1     
+ Partials     1622     1620       -2     
Flag Coverage Δ
admin 11.47% <ø> (-0.06%) ⬇️
agent 52.74% <ø> (+0.13%) ⬆️
managed 46.76% <23.07%> (-0.01%) ⬇️
vmproxy 66.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

managed/services/user/user.go Outdated Show resolved Hide resolved
managed/services/user/user.go Show resolved Hide resolved
@ademidoff ademidoff changed the title PMM-13076 snooze updates PMM-12910 snooze updates Jun 10, 2024
managed/services/user/user.go Show resolved Hide resolved
managed/services/user/user.go Outdated Show resolved Hide resolved
api/userpb/user.proto Outdated Show resolved Hide resolved
managed/models/user_flags_helpers.go Outdated Show resolved Hide resolved
@idoqo idoqo requested review from ademidoff and BupycHuk July 24, 2024 08:41
@idoqo idoqo merged commit 0be6f30 into v3 Aug 19, 2024
29 checks passed
@idoqo idoqo deleted the PMM-13076-snooze-updates branch August 19, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants