Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to buf schema v2 and move api related tasks to dedicated Makefile for PMM v3 #3178

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

artemgavrilov
Copy link
Contributor

PMM-7

Link to the Feature Build: SUBMODULES-0

Same as #3176 but for V3

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.51%. Comparing base (11cba1b) to head (08ac38c).
Report is 1 commits behind head on v3.

Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #3178      +/-   ##
==========================================
- Coverage   44.54%   44.51%   -0.03%     
==========================================
  Files         357      357              
  Lines       35594    35594              
==========================================
- Hits        15856    15846      -10     
- Misses      18115    18126      +11     
+ Partials     1623     1622       -1     
Flag Coverage Δ
admin 11.52% <ø> (ø)
agent 52.66% <ø> (-0.14%) ⬇️
managed 46.65% <ø> (+<0.01%) ⬆️
vmproxy 66.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@artemgavrilov artemgavrilov marked this pull request as ready for review August 26, 2024 14:03
@artemgavrilov artemgavrilov requested review from a team and BupycHuk as code owners August 26, 2024 14:03
@artemgavrilov artemgavrilov requested review from ademidoff, idoqo and JiriCtvrtka and removed request for a team August 26, 2024 14:03
@JiriCtvrtka JiriCtvrtka enabled auto-merge (squash) September 9, 2024 11:28
@artemgavrilov artemgavrilov merged commit 4242f0b into v3 Sep 9, 2024
34 of 35 checks passed
@artemgavrilov artemgavrilov deleted the migrate-buf-schema-v2-for-pmmv3 branch September 9, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants