Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-13409 Fix update status failure after upgrade #3234

Merged
merged 12 commits into from
Oct 25, 2024

Conversation

ademidoff
Copy link
Member

@ademidoff ademidoff commented Oct 10, 2024

PMM-13409

Link to the Feature Build: SUBMODULES-3732

@ademidoff ademidoff changed the base branch from main to v3 October 10, 2024 15:57
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 43.44%. Comparing base (92800f8) to head (5b2f065).
Report is 1 commits behind head on v3.

Files with missing lines Patch % Lines
managed/services/server/server.go 11.11% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #3234      +/-   ##
==========================================
+ Coverage   43.41%   43.44%   +0.02%     
==========================================
  Files         360      360              
  Lines       43977    43979       +2     
==========================================
+ Hits        19094    19107      +13     
+ Misses      23223    23210      -13     
- Partials     1660     1662       +2     
Flag Coverage Δ
admin 11.45% <ø> (ø)
agent 51.93% <ø> (+0.12%) ⬆️
managed 45.16% <11.11%> (-0.01%) ⬇️
vmproxy 68.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ademidoff ademidoff marked this pull request as ready for review October 11, 2024 13:07
@ademidoff ademidoff requested a review from a team as a code owner October 11, 2024 13:08
@ademidoff ademidoff requested review from BupycHuk and idoqo and removed request for a team October 11, 2024 13:08
@ademidoff ademidoff requested review from JiriCtvrtka and removed request for JiriCtvrtka October 14, 2024 09:21
Copy link
Contributor

@idoqo idoqo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, with minor comment.

managed/services/server/updater.go Outdated Show resolved Hide resolved
Co-authored-by: Michael Okoko <10512379+idoqo@users.noreply.github.com>
@ademidoff ademidoff requested a review from idoqo October 14, 2024 21:30
@matejkubinec matejkubinec requested a review from a team as a code owner October 22, 2024 07:47
@matejkubinec matejkubinec requested review from matejkubinec and YashSartanpara1 and removed request for a team October 22, 2024 07:47
@matejkubinec matejkubinec merged commit 6e8faed into v3 Oct 25, 2024
32 checks passed
@matejkubinec matejkubinec deleted the PMM-13409-fix-update-status-failure-after-upgrade branch October 25, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants