Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PMM-4172 pt-mysql-summary #600

Merged
merged 26 commits into from
Nov 13, 2020
Merged

PMM-4172 pt-mysql-summary #600

merged 26 commits into from
Nov 13, 2020

Conversation

askomorokhov
Copy link
Contributor

No description provided.

yareach and others added 7 commits October 15, 2020 13:04
@yareach @AlekSi
Added go 1.15.x. (#592)
8704af9 
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@percona.com>
@AlekSi
SAAS-107 Add comments (#581)
d034471
@AlekSi
Merge branch 'PMM-2.0' into release/2.12
20199ee
@AlekSi
PMM-6759 Support GET verb for pmm-agent's API (#589)
937adbc
@artemgavrilov @AlekSi
SAAS-377 Disable checks by name (#588)
e7cb1c4 
* SAAS-377 Add API for checks disabling

* SAAS-377 Make checks API consistent with other PMM APIs

* SAAS-377 Eliminate types collision in swagger generated code

* SAAS-377 Renaming

* SAAS-377 Fix typo

* SAAS-377 Renaming

* SAAS-377 Refactoring

* SAAS-377 Renaming

* SAAS-377 Minor tweaks

Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@percona.com>
PMM-4172 PT MySQL summary.
5b1c990
Merge branch 'release/2.12' into PMM-4172-pt-mysql-summary
e4de635
@rnovikovP rnovikovP changed the title Pmm 4172 pt mysql summary PMM-4172 pt mysql summary Oct 22, 2020
@yareach yareach marked this pull request as ready for review November 6, 2020 12:37
@AlekSi AlekSi changed the title PMM-4172 pt mysql summary PMM-4172 pt-mysql-summary Nov 6, 2020
AlekSi
AlekSi suggested changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ci fails

api/agentpb/agent.proto Outdated Show resolved Hide resolved
BupycHuk
BupycHuk reviewed Nov 11, 2020
View reviewed changes
api/agentpb/agent.proto Outdated Show resolved Hide resolved
BupycHuk
BupycHuk requested changes Nov 12, 2020
View reviewed changes
Copy link
Member

@BupycHuk BupycHuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the reason of shorting field names?

@yareach
Copy link
Contributor

yareach commented Nov 12, 2020

what is the reason of shorting field names?

There is no big reason to use shorten those names. Linux tends to have shorten names. While in Windows for sure I'd used a complete name. To avoid these situations, I suggest having these details specified at the beginning. Are there any difficulties of understanding their meanings?

@BupycHuk
Copy link
Member

there is no any other place in api where we use shorten names, so let's keep using the same style.

@AlekSi
Copy link
Contributor

AlekSi commented Nov 12, 2020

I suggest having these details specified at the beginning

We talked about consistency, aren't we? Let's use the same field names as other APIs in that repo: address, port, socket, username, password

AlekSi
AlekSi reviewed Nov 12, 2020
View reviewed changes
api/agentpb/agent.proto Outdated Show resolved Hide resolved
@yareach yareach requested a review from AlekSi November 12, 2020 11:32
@yareach yareach merged commit f6b182f into PMM-2.0 Nov 13, 2020
@yareach yareach deleted the PMM-4172-pt-mysql-summary branch November 13, 2020 06:55
@BupycHuk
Copy link
Member

@yareach in future please merge all PRs related to the same task in the same time. If any of us will update pmm repo for pmm-managed now build will fail.

JiriCtvrtka pushed a commit that referenced this pull request Nov 16, 2020
@askomorokhov
Revert "PMM-4172 pt-mysql-summary (#600)"
f283358 
This reverts commit f6b182f.
@palash25 palash25 mentioned this pull request Nov 16, 2020
Merged
9 tasks
JiriCtvrtka pushed a commit that referenced this pull request Nov 25, 2020
@askomorokhov
Revert "PMM-4172 pt-mysql-summary (#600)"
db10799 
This reverts commit f6b182f.
JiriCtvrtka pushed a commit that referenced this pull request Nov 25, 2020
@askomorokhov
Revert "PMM-4172 pt-mysql-summary (#600)"
a30745d 
This reverts commit f6b182f.
AlekSi pushed a commit that referenced this pull request Nov 25, 2020
@JiriCtvrtka @askomorokhov
Revert "PMM-4172 pt-mysql-summary (#600)" (#623)
910a01a 
This reverts commit f6b182f.

Co-authored-by: Andrii Skomorokhov <askomorokhov@users.noreply.github.com>
AlekSi added a commit that referenced this pull request Nov 25, 2020
@AlekSi
Revert "Revert "PMM-4172 pt-mysql-summary (#600)" (#623)"
3e291c4 
This reverts commit 910a01a.
JiriCtvrtka pushed a commit that referenced this pull request Nov 25, 2020
@askomorokhov
Revert "Revert "PMM-4172 pt-mysql-summary (#600)""
4587c53 
This reverts commit db10799.
@yareach yareach restored the PMM-4172-pt-mysql-summary branch November 26, 2020 14:36
BupycHuk added a commit that referenced this pull request Dec 29, 2020
@JiriCtvrtka @askomorokhov
@AlekSi @BupycHuk
PMM-5364 SSL support for Mongo. (#618)
3776869 
* PMM-5364 Changes.

* PMM-5364 Changes.

* PMM-5364 Fix names.

* PMM-5364 Gen.

* PMM-5364 Also add fileds into management.

* Revert "PMM-4172 pt-mysql-summary (#600)"

This reverts commit f6b182f.

* Revert "Revert "PMM-4172 pt-mysql-summary (#600)""

This reverts commit db10799.

* PMM-5364 Add fields also for QAN MongoDB profiler.

* PMM-5364 Gen.

* PMM-5364 Tweak comments

* PMM-5364 Add cert fields also for mongo actions.

* PMM-5364 Gen.

* PMM-5364 Gen.

* PMM-5364 Fix.

* PMM-5364 Renaming.

* PMM-5367 Gen.

* PM-5364 Field name typo fix.

* PMM-5364 Fix typo in other places.

* PMM-5364 Replace mongodb_options with files map.

* PMM-5364 Add delimiters.

* PMM-5364 Add text files to built-in agents.

* PMM-5364 Add comments.

* PMM-5364 Removed unnecessary struct.

Co-authored-by: Andrii Skomorokhov <askomorokhov@users.noreply.github.com>
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@percona.com>
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
Co-authored-by: Nurlan Moldomurov <nurlan.moldomurov@percona.com>
Co-authored-by: Nurlan Moldomurov <bupychuk1989@gmail.com>
BupycHuk added a commit that referenced this pull request Feb 22, 2021
@AlekSi @BupycHuk
@JiriCtvrtka @yareach
Revert "PMM-4172 Revert pt-mysql-summary (#600)." (#624)
37c694d 
* Revert "Revert "PMM-4172 pt-mysql-summary (#600)" (#623)"

This reverts commit 910a01a.

* PMM-6982 IA settings API (#620)

* PMM-6982 Add comments

* PMM-6982 IA settings API

* PMM-6982 Add initialism

* PMM-6982 Fix typo

* Add summary to Rule (#631)

* PMM-6982 Add API for togging IA (#636)

* PMM-7108 Fix reform version (#638)

* PMM-6827 DB cluster monitoring. (#625)

* PMM-6826 Add disk size to create API.

* PMM-6826 Use bytes instead of megabytes.

* PMM-6826 Make disk size required field.

* PMM-6827 Add public address to Settings API

* PMM-6827 Add ability to remove public address.

* PMM-6827 rename public address to pmm public address.

* PMM-6827 rename public address to pmm public address.

* PMM-6827 Fix merge conflicts.

* PMM-6827 Fix merge conflicts.

Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@percona.com>

* PMM-6983 Add force for unregister k8s (#633)

* PMM-6959 Update API descriptors. (#632)

* PMM-6983 Add bool fields into unregister k8s.

* PMM-6983 Revert api descriptors.

* PMM-6983 Fix.

* PMM-6983 Add comment to force option.

* PMM-6983 Change comment.

Co-authored-by: Nurlan Moldomurov <bupychuk1989@gmail.com>

* PMM-4172 Renamed address to host.

* PMM-4172 Fix conflict.

* Regenerate

* PMM-4172 Make gen.

Co-authored-by: Jaroslav Musil <jaroslav.musil.sde@gmail.com>
Co-authored-by: Nurlan Moldomurov <bupychuk1989@gmail.com>
Co-authored-by: JiriCtvrtka <62988319+JiriCtvrtka@users.noreply.github.com>
Co-authored-by: Jaroslav Musil <49949480+yareach@users.noreply.github.com>
Co-authored-by: Jiri Ctvrtka <jiri.ctvrtka.sde@gmail.com>
nicolalamacchia added a commit that referenced this pull request Feb 23, 2021
@nicolalamacchia
Merge branch 'PMM-2.0' into PMM-7337-stt-check-intervals
babfaef 
* PMM-2.0:
  Remove myself from CODEOWNERS
  Revert "PMM-4172 Revert pt-mysql-summary (#600)." (#624)
  PMM-5784 pt-pg-summary. (#614)
artemgavrilov pushed a commit that referenced this pull request Jun 17, 2022
@AlekSi
PMM-7214 Fix/simplify configuration reload (#600)
0e15538 
* PMM-7214 Add RequestConfigurationUpdate stub

* PMM-7214 Unify VM and VMAlert configuration handling

* PMM-7214 Regenerate configuration on startup

* PMM-7214 Minor cleanup

* PMM-7214 Rework Alertmanager configuration

* PMM-7214 Fix typo

* PMM-7214 Fix reload

* PMM-7214 Minor tweaks

* PMM-7214 Fix dep

* PMM-7214 Ensure working alertmanager.yml

* PMM-7214 Move directory creation

* PMM-7214 Fix upgrade

* PMM-7214 Add more files to logs.zip

* PMM-7214 Add more files to logs

* PMM-7214 Fix startup

* PMM-7214 Fix tests

* PMM-7214 Fix startup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yareach yareach yareach left review comments

@percona-csalguero percona-csalguero percona-csalguero approved these changes

@BupycHuk BupycHuk BupycHuk approved these changes

@AlekSi AlekSi AlekSi approved these changes

Assignees

@yareach yareach

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@askomorokhov @yareach @BupycHuk @AlekSi @percona-csalguero @artemgavrilov @JiriCtvrtka