Errors attempting to upload multiple resources with the same resource url

[swissspidy]

We're using @percy/cli (1.0.0-beta.54) together with @percy/puppeteer (2.0.0) and are facing a situation where Percy errors uploading screenshots because resource URLs are identical.

Here's an example scenario where this happens:

await page.goto('http://localhost:8000');

await percySnapshot(page, 'With JS');

await page.setJavaScriptEnabled(false);

await page.goto('http://localhost:8000');

await percySnapshot(page, 'Without JS');

await page.setJavaScriptEnabled(true);

But this can of course also happen when taking multiple screenshots in an SPA where the URL never changes:

await page.goto('http://localhost:8000');

await percySnapshot(page, 'Initial state');

await page.click('#button_that_opens_modal');

await percySnapshot(page, 'Modal open');

Is this something you can fix? If not, any advice on how to prevent this on our side?

[Robdel12]

Hey @swissspidy! Would you be able to share logs or build details? The only thing that's required to be unique is the name.

[swissspidy]

Here's a recent CI log:

https://github.com/google/web-stories-wp/runs/2896753308#step:13:18

The first error there is originating from this place where we call percySnapshot():

https://github.com/google/web-stories-wp/blob/a8f73d2aaaf567016dd4780c331ab4e05fb12363/packages/e2e-tests/src/specs/wordpress/pluginActivation.js#L36-L54

Also worth noting that we're doing jest.retryTimes(3); in our test suite to automatically retry failing tests in cases of errors. That might play a role here too.

[Robdel12]

Sweet, thanks for that! I can see that the root resource is for some reason being discovered/captured in asset discovery, which is a big no. We'll keep digging to see why that's happening -- it shouldn't ever make its away into the discovery queue 🤨

Also worth noting that we're doing jest.retryTimes(3); in our test suite to automatically retry failing tests in cases of errors. That might play a role here too.

That's not the issue now, but that will cause issues if there is a retried test. Percy snapshots can't be retried (for now, we're working on making snapshot creation lazy for these cases). Any retried test with a snapshot in it, will throw errors.

[Robdel12]

Alright, @swissspidy this should be fixed in v1.0.0-beta.55 😃 https://www.npmjs.com/package/@percy/cli/v/1.0.0-beta.55 Thanks for raising the issue!

[swissspidy]

Awesome, thank you so much for this quick turnaround! It works like a charm now.