🐛 Fix bug when providing execute without before snapshot #529
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
Thanks to @cancan101 for testing out the new
execute
features from #514 and finding a bug. Whenexecute
is provided without abeforeSnapshot
option, the entireexecute
object is passed on to the evaluate function, which creates an unserializable function as a result.Rather than coalesce the
execute
option, we can typecheck if it is a function and fallback toexecute?.beforeSnapshot
.