feat: Update getBuilds filter param to support array values #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhaines
changed the title
Robdel12
approved these changes
Oct 28, 2019
src/main.js
Outdated
| if (Array.isArray(filter[key])) { | ||
| // If filter value is an array, match Percy API's format expectations of: | ||
| // filter[key][]=value1&filter[key][]=value2 | ||
| return filter[key].map(array_value => 'filter[' + key + '][]=' + array_value).join('&'); |
There was a problem hiding this comment.
A little picky, but we could interpolate rather than concat:
return filter[key].map(array_value => `filter[${key}][]=${array_value}`).join('&');There was a problem hiding this comment.
Pickiness of the good kind. Will update and merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Percy's getBuilds API endpoint now supports a few new params: branch, state, and shas.
shasis an array of values.This PR adds support to getBuilds for handling filter params with array values.