-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new Azure DevOps PullRequestNumber env var #257
Conversation
environment._env.SYSTEM_PULLREQUEST_PULLREQUESTID = '512'; | ||
environment._env.SYSTEM_PULLREQUEST_PULLREQUESTNUMBER = '524'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure if we'll need to add another variable to the CLI for the case a GitHub PR triggers an Azure DevOps build. From my tests so far env.SYSTEM_PULLREQUEST_PULLREQUESTNUMBER
has always been null
This variable is populated for pull requests from GitHub which have a different pull request ID and pull request number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🦄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎮
Could we get the same change over in @percy/env? 😃
Update here: holding off on merging since we might have to change more env variables to get the correct branch name, too. Additionally, I've shifted focus to ensuring we can fetch this information asynchronously via the APIs before integrating preemptive changes to the SDK. Will revisit this mid next week, when I predict I'll have a better understanding of what other minor changes would have to be made to the SDK to support Azure DevOps |
90ed4a5
to
d8bf398
Compare
Was looking into capturing additional environment variables, but might not be as valuable in the grand scheme of things since it would require a great deal of refactoring. Will create a new PR if the need arises. |
Add support for Azure DevOps change in pull request number environment variable
https://docs.microsoft.com/en-us/azure/devops/pipelines/build/variables?view=azure-devops&tabs=yaml#system-variables-devops-services