🐛 Remove Dynamic import now that @percy/sdk-utils is commonjs
#430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwilsman
reviewed
May 9, 2022
We convereted `@percy/sdk-utils` to be ESM for 1.x, and this causes a lot of various issues. That has since been reverted (it's back to commonjs) so we can remove the dynamic import to fully remove any issues with ESM.
Robdel12
force-pushed
the
rd/no-dynamic-import
branch
from
35c3056
to
5bb0ee0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
We converted
@percy/sdk-utilsto be ESM for 1.x, and this causes a lot of various issues. That has since been reverted (it's back to commonjs with percy/cli#916) so we can remove the dynamic import to fully remove any issues with ESM.